Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests #9

Closed
curran opened this issue Dec 29, 2020 · 4 comments
Closed

Fix Tests #9

curran opened this issue Dec 29, 2020 · 4 comments

Comments

@curran
Copy link
Contributor

curran commented Dec 29, 2020

User Story: As a developer who is new to this project and looking to work on modernizing the distribution, I want to have a stable test harness to check what things break and how they break along the way towards modernization.

@curran
Copy link
Contributor Author

curran commented Dec 29, 2020

To run the tests, I ran make install and make test.

The first broken test is this one:

    order 
      ✗ insert-simple 
      Invalid list, indices not sorted 

That test is defined here in the code, if anyone has capacity to investigate: https://github.com/jdfekete/reorder.js/blob/master/test/order-test.js#L151

@jdfekete
Copy link
Owner

Sure, let me check what's wrong. I have forgotten everything about that code so I need to find out what it is supposed to do.

@curran
Copy link
Contributor Author

curran commented Dec 29, 2020

Hooray! Thank you for jumping in.

@jdfekete
Copy link
Owner

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants