Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show human readable details of syllabification in the CLI tool #10

Open
kikocorreoso opened this issue Apr 20, 2020 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@kikocorreoso
Copy link
Contributor

I was thinking in the addition of a new option for the command line. Something like:

$ pylabeador --full torpedo

That provides a more complete output than just ['tor', 'pe', 'do'].

If you agree i can implement this this week and then you can prepare a new release. If you don't like the enhancement just close it and prepare the new release 👍

@jdevera
Copy link
Owner

jdevera commented Apr 20, 2020

So right now the command line tool outputs tor-pe-do for that, I guess you mean to show some output like the stressed syllable and where the accent is, or even more?

What is the use you have in mind for this? Human consumption or other tools?

@kikocorreoso
Copy link
Contributor Author

Mainly human consumption. Just to provide more information from the command line as it is already in the library and it would be easy to also provide this information.

@jdevera
Copy link
Owner

jdevera commented Apr 20, 2020

Let's design the output here. How about this:

Word: drástico
Syllables: drás-ti-co
Stressed syllable: 1 drás *drás*tico
Accent: 3 á dr*á*stico

This would use 1-based indexing (for humans :P) for both stressed and accented.

I'm not sure about the use of outputting the accented letter since it is visible, but I do not have a use for this and you do, so please let me know what you think.

@jdevera jdevera added the enhancement New feature or request label Apr 20, 2020
@kikocorreoso
Copy link
Contributor Author

Yes, something like this.

I'm thinking in an educational resource for kids and, maybe, for foreigners that are learning spanish and could be confused by the accented vowels. I would remove the numbers in the output as this would be more focused on human consumption. Maybe something like this?

Word: drástico
Syllables: drás-ti-co
Stressed syllable: *drás*tico
                    ^^^^
Accent: dr*á*stico
           ^

OTOH, this could be inplemented in an easy way by one consuming the pylabeador API so, please, decide, if you would like this included or do you prefer to KISS:

$ pylabeadorl drástico
drás-ti-co
$ pylabeador --full drástico
Word: drástico
Syllables: drás-ti-co
Stressed syllable: *drás*tico
                    ^^^^
Accent: dr*á*stico
           ^

@jdevera
Copy link
Owner

jdevera commented Aug 2, 2020

Sorry for leaving this hanging for so long without an answer. I'm not working on this immediately but not closing it either. I'd like to prioritize changes with a practical application, rather than enhancing the tool to cater for possible uses, I hope that is understandable.

@jdevera jdevera changed the title [ENH] Adding an option --full for the command line Show human readable details of syllabification in the CLI tool Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants