Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport missing ProjectSnippet and ProjectBadges #86

Merged
merged 1 commit into from
May 15, 2018

Conversation

pablobirukov
Copy link
Contributor

@pablobirukov pablobirukov commented May 15, 2018

I started typescript introduction and the first problem I've discovered is missing exports.

ProjectBadges was empty because of lost re-export in services/index.js and ProjectSnippets was empty because it was re-exported under wrong name (ProjectSnippet)

@jdalrymple jdalrymple merged commit 8260433 into jdalrymple:master May 15, 2018
@jdalrymple
Copy link
Owner

Nice catch!

@pablobirukov pablobirukov deleted the fix-reexport branch May 16, 2018 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants