Retrieving events

[xtr3me]

When trying to retrieve all events from a project via the new Event service i came across the following difference between this package and the gitlab api:

https://docs.gitlab.com/ee/api/events.html#list-a-project-39-s-visible-events
The API states that: action and targetType are optional yet this package makes them mandatory as seen in: https://github.com/jdalrymple/node-gitlab-api/blob/4e78749edcd6022736cb8c0471df008de2fc3d19/src/services/Events.js#L27

This prevents me from using the Events service as i cant retrieve all the events.

(ps. i'm only interested in pushed events on the project, but i get an empty response when using:
{ action: 'pushed', targetType: 'project' }, that's how i found the difference between the API and the Service)
(ps2. how can i see the complete response and not only the parsed response for debugging purposes)

[jdalrymple]

Must of missed that! Hmm right now the full responses are hidden for clarity, but maybe adding a debug option to expose those would be helpful

[xtr3me]

I can make a PR, do you want to remove the validateEventOptions all together or do you have a different idea about that?

[jdalrymple]

That would be amazing if you dont mind! I think validateEventOptions should still be used, but only validate if the options exist. If they dont exist it should assume things are valid. Not sure what the best way to go about that would be. Maybe

function validateEventOptions(action, target) {
  if (action && !ACTION_TYPES.includes(action)) {
    throw new Error(`This action is not supported. Pleased use one of following options: ${ACTION_TYPES}`);
  }

  if (target && !TARGET_TYPES.includes(target)) {
    throw new Error(`This target is not supported. Pleased use one of following options: ${TARGET_TYPES}`);
  }
}

[jdalrymple]

Fixing it now :)

[jdalrymple]

Should be fixed now!

[hsablonniere]

Hey @jdalrymple ;-)

In 4.2.2, the action and target are still required:
https://github.com/jdalrymple/node-gitlab/blob/4.2.2/src/services/Events.ts#L32-L36

I would like to list all events with after and before but without any types...

[jdalrymple]

Oh man, sorry :( Ill look soon

[jdalrymple]

Just released to npm and the next build!

[hsablonniere]

@jdalrymple Thanks very much for doing it so fast. In the hurry you made a small mistake.

You wrote:

if (action || !(action in ACTION_TYPES)) {
/// ...
if (target || !(target in TARGET_TYPES)) {

instead of:

if (action && !(action in ACTION_TYPES)) {
/// ...
if (target && !(target in TARGET_TYPES)) {

[jdalrymple]

Oops! One moment!

[hsablonniere]

@jdalrymple It works!! 🎉 Thanks very much!