Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding support for profile tokens #462

Merged
merged 9 commits into from
Oct 12, 2019
Merged

feat: Adding support for profile tokens #462

merged 9 commits into from
Oct 12, 2019

Conversation

jdalrymple
Copy link
Owner

@jdalrymple jdalrymple commented Oct 10, 2019 •
edited
Loading

@jetersen
Copy link
Contributor

CI failed 😓

jetersen
jetersen approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdalrymple
Copy link
Owner Author

Yea, I can't fix the linting issues on my current pc :( It will have to wait until I get home for me to fix it.

@jetersen
Copy link
Contributor

Gogo docker?

docker run --rm -it -w /src -v ${PWD}:/src node
npm i
npm run lint:fix
npm run lint:doc:fix

@jdalrymple
Copy link
Owner Author

Also don't have docker locally lol :P

@jetersen
Copy link
Contributor

Why wouldn't you 😆

@jdalrymple jdalrymple merged commit 30f246e into master Oct 12, 2019
jdalrymple pushed a commit that referenced this pull request Oct 12, 2019
@semantic-release-bot
chore(release): 11.3.0 [skip ci]
10d74d2 
# [11.3.0](11.2.3...11.3.0) (2019-10-12)

### Features

* Adding support for profile tokens ([#462](#462)) ([30f246e](30f246e))
@jdalrymple
Copy link
Owner Author

🎉 This PR is included in version 11.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jdalrymple jdalrymple deleted the 441-profile-token branch October 12, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HTTP header X-Profile-Token
2 participants
@jdalrymple @jetersen