feat: Add configurable request timeout #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalrymple
changed the title
jdalrymple
pushed a commit
that referenced
this pull request
Jun 8, 2019
# [6.3.0](6.2.0...6.3.0) (2019-06-08) ### Features * Add configurable request timeout ([#341](#341)) ([4d99902](4d99902))
|
🎉 This PR is included in version 6.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making requests against large instances (say get all public projects of gitlab.com) the calls appear to hang, but in reality it's just that the request timeout is set to 300 seconds. This PR adds the ability for the client to configure the timeout (default is still 300 seconds) so that we can timeout for clients that need to do so.