fix: obey rate limits for all request types correctly #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetersen
reviewed
Aug 22, 2018
| @@ -1,4 +1,7 @@ | |||
| import { RequestHelper } from '../../../src/infrastructure'; | |||
| import Gitlab from '../../..'; | |||
There was a problem hiding this comment.
Should be '../../../src'
Please fix the import statement: https://travis-ci.org/jdalrymple/node-gitlab/jobs/419127291#L3209-L3210
max-wittig
changed the title
max-wittig
changed the title
|
I sadly had to drop the tests, as jest runs out of order and in parallel. |
jdalrymple
reviewed
Aug 22, 2018
src/infrastructure/RequestHelper.js
Outdated
| }); | ||
| try { | ||
| if (type === 'get') { |
There was a problem hiding this comment.
wouldnt a switch statement here be better?
|
@jdalrymple Any blockers? I think the pipeline failure is a random occurrance. Right? |
|
Looks like a few of the properties changed in the application settings test. Just need to add the missing props |
jdalrymple
pushed a commit
that referenced
this pull request
Aug 28, 2018
|
🎉 This PR is included in version 3.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jdalrymple
added a commit
that referenced
this pull request
Aug 28, 2018
|
@jdalrymple Sorry I haven't found the time to adjust the tests. |
jdalrymple
added a commit
that referenced
this pull request
Sep 5, 2018
* chore: Introduce typescript * chore: Remove lodash.pick, use native js instead * chore: Add tslint and extend Airbnb ruleset * chore: Remove Babel Dependency, replace build steps with tsc * chore: change target for modern env from es2017 to es6 (async/await should be transpiled to downlevel js) * chore(package): Updating packages * fix: Fix error while throwing an error in RequestHelper (#156) * feat: Support rejectUnauthorized parameter (#164) * feat: Adding project archive abilities * fix(test): Application settings API updated (#177) * fix: Removing token requirement (#176) * chore: Removing npmignore and using files instead. * fix: obey rate limits for all request types correctly (#170) * fix: Camel casing broke the body params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for #169 to be merged