Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main ApnsClientThread terminates on connection failure #5

Closed
andrewscode opened this issue Sep 24, 2013 · 9 comments
Closed

Main ApnsClientThread terminates on connection failure #5

andrewscode opened this issue Sep 24, 2013 · 9 comments
Labels
Milestone

Comments

@andrewscode
Copy link

If an error occurs connecting to apple (ssl handshake, unknown host, etc), the main ApnsClientThread will terminate and never try to reconnect.

in run():

                case CONNECT: {
                    try {
                        this.connect();
                    } catch (InterruptedException e) {
                        continue;
                    }

In my case, a javax.net.ssl.SSLException is thrown and the thread permenantly exists.

A simple test case is to disable any connection to the internet. Then try to start the push manager. The thread will stop on first attempted connect.

@andrewscode
Copy link
Author

Looking at the source, I think this issue has been fixed (but not released)

@jchambers
Copy link
Owner

I think you're right that this is fixed in master, but #4 should put even more nails in that particular coffin (particularly ea71c80). Planning on putting out a release shortly after we get #4 reviewed and merged.

@danmassie
Copy link

Any idea when this fix will be released?

@jchambers
Copy link
Owner

@danmassie This is already fixed in master (and please let me know if that doesn't appear to be true for you). We're expecting to do a new release shortly. #6 is the last thing on the to-do list before putting out v0.2.

@danmassie
Copy link

@jchambers Yes it appears to be fixed in master, but its obviously not ideal to be depending on a snapshot.

@agarajh
Copy link

agarajh commented Nov 11, 2013

Hello I have the following problem: The main thread is reconnecting ( appears to be fixed in master ). Still the notifications which were pushed while I/0 problems occurred ( like missing internet connection) are never pushed to APNS Server after the main thread reconnects. Only new push notifications are being sent. Do you know why this is happening?

@jchambers
Copy link
Owner

@agarajh Could you please (a) open a separate issue for that and (b) provide some more details about the kind of connection failure you're seeing?

@jchambers
Copy link
Owner

@danmassie v0.2 has been released (see https://github.com/relayrides/pushy/releases/tag/pushy-0.2) and should be available in the central repository within a couple hours.

@danmassie
Copy link

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants