Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop coordinate values of bound and vertex dimensions? #176

Closed
jbusecke opened this issue Jul 28, 2021 · 2 comments · Fixed by #183
Closed

Drop coordinate values of bound and vertex dimensions? #176

jbusecke opened this issue Jul 28, 2021 · 2 comments · Fixed by #183
Assignees

Comments

@jbusecke
Copy link
Owner

I ran into some trouble with concating/mergin datasets that had different values for e.g. bnds. Some datasets do have a different datatype (int vs float) and then others use a [1,2] convention instead of [0,1].

I think we can just add

ds = ds.drop({d for d in ['bnds', 'verticies'] if d in ds.dims})

to the combined_preprocessing without loosing functionality? Or am I missing an important use case from anyone?

cc @dcherian

@jbusecke jbusecke self-assigned this Jul 28, 2021
@dcherian
Copy link

Sounds fine to me. What are the float values: 0.0, 1.0?

@jbusecke
Copy link
Owner Author

I have found several array([1., 2.]), ones in there...damn you MATLAB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants