Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knex 1.x support #131

Open
jbergstroem opened this issue Jan 18, 2022 · 6 comments
Open

Knex 1.x support #131

jbergstroem opened this issue Jan 18, 2022 · 6 comments

Comments

@jbergstroem
Copy link

Creating a tracking issue for 1.x support in case someone else stumbles in.

@RuslanUshakov
Copy link

Facing with an issue like this (knex 1.0.3)
image

@RuslanUshakov
Copy link

@jbergstroem ^^

@jbergstroem
Copy link
Author

@RuslanUshakov I believe you are saying the same thing as I am. The next step woudl be for someone to file a PR to fix it (and with the help of the maintainer, land said pr/release a new version).

@mir1198yusuf
Copy link

By when this PR will be merged ?

@mlarcher
Copy link

mlarcher commented May 19, 2022

is it just a matter of merging/releasing or is there more to it ? @jbrumwell

It would be really nice to be able to upgrade to recent versions of knex and still use this awesome package!

I can't even imagine how others are doing without it, as inMemory db and manual mocking don't look like really viable solutions to me. Strangely enough I can't find anything on the matter through google searches. Any hint would be appreciated in case I'm just not seeing something obvious...

@mir1198yusuf
Copy link

Use this @mlarcher
felixmosh/knex-mock-client#17

If you want a similar way of doing (i.e. to be able to use step variable )
felixmosh/knex-mock-client#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants