Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removing the knex version limitation #109

Open
SamMaxwell opened this issue Nov 6, 2019 · 5 comments
Open

consider removing the knex version limitation #109

SamMaxwell opened this issue Nov 6, 2019 · 5 comments

Comments

@SamMaxwell
Copy link

SamMaxwell commented Nov 6, 2019

I have been using (and very much enjoying) mock-knex for many months.

But I am frustrated that it has often prevented me from staying up-to-date with knex.

I would accept a mocking library that isn't immediately up-to-date with any new classes/methods that the library it mocks releases at any given moment. I would know it immediately when I use a some brand new knex feature that there may not be a mock for it.

But when my code hasn't changed at all and I simply want to upgrade to latest knex, that I cannot test ANYTHING in my code that uses knex. So for now I just stay a few versions back and wait for mock-knex to catch up.

Unless this changes, the day may come when I (very reluctantly) am forced to remove mock-knex.

I hope that day never comes.

@SamMaxwell
Copy link
Author

SamMaxwell commented Jan 9, 2020

mock-knex is now 7 releases behind knex. the tail is wagging the dog. does anyone else have an opinion on this matter? is this repo going dead?

@jbrumwell
Copy link
Owner

@SamMaxwell not sure I understand, knex version is 0.20.4 and we currently support that version.

@SamMaxwell
Copy link
Author

@jbrumwell that is good news, but npm shows this ... image

@jbrumwell
Copy link
Owner

@SamMaxwell Thank you for pointing that out I'll update the readme

@felixmosh
Copy link

Try knex-mock-client, it is not bound to a specific knex version.

I've developed it since this lib doesn't progresses with knex fast enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants