This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Cleanup and more methods #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #10
| return new Buffer(s, 'hex') | ||
| } | ||
|
|
||
| exports.toB58String = function toB58String (m) { |
There was a problem hiding this comment.
we've been using the toSomething as obj.toNewFormat. Since this is a utility function and not something available on the object, I would prefer and argue it would be less confusing if instead of 'to' we use the word 'convert' or 'transform'
There was a problem hiding this comment.
that would make these very long, e.g.
multihash.convertToB58String(myBuffer)
// compared to
multihash.toB58String(myBuffer)Because you call it on the module I fell it's pretty clear that you convert from multihash to
|
@diasdavid also added api docs :) |
|
|
||
| - `code: Number` | ||
|
|
||
| Checks wether a code is part of the app range. |
There was a problem hiding this comment.
Anything between 0 and 0x10. I'm not a 100% sure where in the spec they are defined
|
LGTM :) |
|
released 0.2.2 :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.