pin redis-py to 3.x until 4.x breaking changes can be addressed #570
Conversation
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
======================================
Coverage 57.7% 57.7%
======================================
Files 39 39
Lines 2497 2497
Branches 63 63
======================================
Hits 1440 1440
Misses 1049 1049
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
LGTM |
|
Is it possibile to not check for coverage on tests directory but only check types in tests directory? |
Is that why it's codecov is complaining? I figured it was not enough typing over there. Let me look at the config. |
|
It should be excluding the tests: Lines 46 to 49 in 9cd2bbe |
|
I think what you're seeing is that Mypy is complaining about any |
|
Is there a description of the problem or an associated issue that details what issues |
|
@jacklinke right now what's known is #542. I had created #569 which may have been more clear, but it was closed as a dup of #542. I understand the problem, but haven't had time to adjust the code. It does seem like it will be a "decent" amount of work because redis 4 separates sentinel and non sentinel connection pools a bit more. This is probably a good thing since you can configure the connection settings more independently, but not how I had written #460 and the code will need a little re-work. After that we would need to look for any other breaking changes and make sure we have sufficient test coverage to make sure expectations continue to be met regardless if breaking changes are documented or not. |
|
@terencehonles regarding tests, Would you mind taking a look and get back to me? |
|
@WisdomPill do you mind creating a separate issue to discuss and research that? We probably don't need to keep bumping this thread with relation to a change like that. |
Upstream commit redis/redis-py@d2b2333 that is included with redis-py >=4.0.2 adds method Redis.sentinel_masters by making class Redis inherit from SentinelCommands, where the related code resides. Related to issue jazzband#542, follow-up to pull request jazzband#570
…ed (jazzband#570)" This reverts commit ef945d6.
Upstream commit redis/redis-py@d2b2333 that is included with redis-py >=4.0.2 adds method Redis.sentinel_masters by making class Redis inherit from SentinelCommands, where the related code resides. Related to issue jazzband#542, follow-up to pull request jazzband#570
Upstream commit redis/redis-py@d2b2333 that is included with redis-py >=4.0.2 adds method Redis.sentinel_masters by making class Redis inherit from SentinelCommands, where the related code resides. Related to issue jazzband#542, follow-up to pull request jazzband#570
…, jazzband#570) Upstream commit redis/redis-py@d2b2333 that is included with redis-py >=4.0.2 adds method Redis.sentinel_masters by making class Redis inherit from SentinelCommands, where the related code resides. Related to issue jazzband#542, follow-up to pull request jazzband#570 This reverts (parts of) commit ef945d6.
…, jazzband#570) Upstream commit redis/redis-py@d2b2333 that is included with redis-py >=4.0.2 adds method Redis.sentinel_masters by making class Redis inherit from SentinelCommands, where the related code resides. Related to issue jazzband#542, follow-up to pull request jazzband#570 This reverts (parts of) commit ef945d6.
#576) Upstream commit redis/redis-py@d2b2333 that is included with redis-py >=4.0.2 adds method Redis.sentinel_masters by making class Redis inherit from SentinelCommands, where the related code resides. Related to issue #542, follow-up to pull request #570 This reverts (parts of) commit ef945d6.
No description provided.