-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pt-PT translations #690
Conversation
Pull Request Test Coverage Report for Build 1155
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor fixes and should be good to go.
@n2ygk not sure how to proceed with this, this would be the first entry for translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@n2ygk not sure how to proceed with this, this would be the first entry for translations
I'm OK with translations but we need some ground rules to make sure they are good translations and not just something pasted into Google Translate. How do other projects do this? Have a second native-language speaker review the PR?
@n2ygk hello, when will this pr be merged? I am looking forward to this feature. |
Ugh, I screwed up trying to merge this from command line. See #919 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with my changes...
Added locale folder to project and pt-PT translations in it.
Made some missing strings available for translations too.