-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create remote_port field #668
Comments
Yes, I think it would be useful sometimes to keep the port in As the library removes the port, we need a config to disable this behavior. the config shouldn't be enabled be default to prevent breaking changes. |
Currently the IP value of the This new field would only receive a value through a settings. If it is a valid idea, I can make a PR. |
This also works. please remember to set the new field nullable to won't break the current system.
Then we don't need the config. because adding a new nullable field won't break anything.
Great! |
I wonder if it wouldn't be interesting to keep a record of the port in the logs, in some cases it might be useful to keep this information.
In the middleware it is ignored.
The text was updated successfully, but these errors were encountered: