From b090af7a3cb0935030705ee9a00e3ca0d09bc614 Mon Sep 17 00:00:00 2001
From: Gianmaria Del Monte <39946305+gmgigi96@users.noreply.github.com>
Date: Mon, 17 Apr 2023 12:29:04 +0200
Subject: [PATCH] Fix unshare for EOS storage driver (#3794)

---
 changelog/unreleased/fix-unshare-eos.md | 9 +++++++++
 pkg/eosclient/eosbinary/eosbinary.go    | 1 +
 2 files changed, 10 insertions(+)
 create mode 100644 changelog/unreleased/fix-unshare-eos.md

diff --git a/changelog/unreleased/fix-unshare-eos.md b/changelog/unreleased/fix-unshare-eos.md
new file mode 100644
index 00000000000..bf8df7dc4e8
--- /dev/null
+++ b/changelog/unreleased/fix-unshare-eos.md
@@ -0,0 +1,9 @@
+Bugfix: Fix unshare for EOS storage driver
+
+In the EOS storage driver, the remove acl operation was a no-op.
+After removing a share, the recipient of the share was still able
+to operate on the shared resource.
+Now this has been fixed, removing correctly the ACL from the shared
+resource.
+
+https://github.com/cs3org/reva/pull/3794
diff --git a/pkg/eosclient/eosbinary/eosbinary.go b/pkg/eosclient/eosbinary/eosbinary.go
index fca2194f327..b120719363f 100644
--- a/pkg/eosclient/eosbinary/eosbinary.go
+++ b/pkg/eosclient/eosbinary/eosbinary.go
@@ -314,6 +314,7 @@ func (c *Client) RemoveACL(ctx context.Context, auth, rootAuth eosclient.Authori
 		return err
 	}
 
+	a.Permissions = ""
 	sysACL := a.CitrineSerialize()
 	args := []string{"acl", "--sys"}
 	if finfo.IsDir {