We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello! I've noticed that the groupby() typings for dataframes do not follow the intended implementation of the groupby() function.
groupby()
The documentation here: https://github.com/opensource9ja/danfojs/blob/146ba82ca723527f5c2008b5077c6a13d196e01f/danfojs-browser/src/core/frame.js#L2310 states that the col parameter is a list of (string) columns, while the typing here: https://github.com/opensource9ja/danfojs/blob/146ba82ca723527f5c2008b5077c6a13d196e01f/danfojs-browser/types/core/frame.d.ts#L554 declares that the function only takes in a string value. This will probably lead to errors when used, since string values are not mappable.
col
Also, perhaps this parameter can be made optional by allowing it to be undefined?
The text was updated successfully, but these errors were encountered:
Thanks for raising this. @steveoni Can you update this
Sorry, something went wrong.
Fixed!
steveoni
No branches or pull requests
Hello! I've noticed that the
groupby()
typings for dataframes do not follow the intended implementation of thegroupby()
function.The documentation here:
https://github.com/opensource9ja/danfojs/blob/146ba82ca723527f5c2008b5077c6a13d196e01f/danfojs-browser/src/core/frame.js#L2310
states that the
col
parameter is a list of (string) columns, while the typing here:https://github.com/opensource9ja/danfojs/blob/146ba82ca723527f5c2008b5077c6a13d196e01f/danfojs-browser/types/core/frame.d.ts#L554
declares that the function only takes in a string value. This will probably lead to errors when used, since string values are not mappable.
Also, perhaps this parameter can be made optional by allowing it to be undefined?
The text was updated successfully, but these errors were encountered: