Fix LOOKAHEAD for ReferenceType; fixes #2879

[mernst]

Fixes #2879.

[MysterAitch]

Good shout, thanks @mernst ! :)

How do you feel about using LOOKAHEAD(ReferenceType(annotations)) instead, to reduce the duplicated logic of "array of primitives or a class/interface name"?

Depending on the generated parser code, I imagine yours may be a little more performant though?

[codecov]

Codecov Report

Merging #2904 (7552860) into master (e3240fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2904   +/-   ##
=======================================
  Coverage   52.19%   52.19%           
=======================================
  Files         438      438           
  Lines       23436    23436           
  Branches     3535     3535           
=======================================
  Hits        12232    12232           
  Misses      10291    10291           
  Partials      913      913           

Flag	Coverage Δ
AlsoSlowTests	52.19% <ø> (ø)
jdk-10	52.19% <ø> (ø)
jdk-11	52.18% <ø> (ø)
jdk-12	52.18% <ø> (ø)
jdk-13	52.18% <ø> (ø)
jdk-14	52.18% <ø> (ø)
jdk-15	52.18% <ø> (ø)
jdk-8	52.19% <ø> (ø)
jdk-9	52.19% <ø> (ø)
macos-latest	52.18% <ø> (ø)
ubuntu-latest	52.18% <ø> (-0.01%)	⬇️
windows-latest	52.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3240fc...e931cdd. Read the comment docs.

[mernst]

How do you feel about using LOOKAHEAD(ReferenceType(annotations)) instead, to reduce the duplicated logic of "array of primitives or a class/interface name"?

I think that would work. It does seem less efficient since it requires lookahead through the entire reference type rather than only looking ahead far enough to distinguish the shift conflict.

[MysterAitch]

Travis is being a pain with queues/delays, so merging without waiting for it :)

[mernst]

@MysterAitch Thanks for merging.

[MysterAitch]

@mernst Thank you for giving me something to merge!! It really is appreciated 👍