Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for issue #1793 Cloning problems with LexicalPreserving… #2843

Merged
merged 3 commits into from
Oct 18, 2020
Merged

Add test case for issue #1793 Cloning problems with LexicalPreserving… #2843

merged 3 commits into from
Oct 18, 2020

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Oct 18, 2020

…Printer (using 3.6.18)

Fixes #1793.

@jlerbsc
Copy link
Collaborator Author

jlerbsc commented Oct 18, 2020

@maartenc There are errors in this build which are not related to my work! have you an idea? Perhaps it's related to line separator.
There are also many java.lang.OutOfMemoryError: GC overhead limit exceeded

@maartenc
Copy link
Contributor

@jlerbsc : just a guess, but in the testcase you use some static method to configure things, which might have an influence on the other junit tests. Maybe this setup requires more memory?

StaticJavaParser.setConfiguration(new ParserConfiguration().setLexicalPreservationEnabled(true));
CompilationUnit cu = StaticJavaParser.parse(src);
LexicalPreservingPrinter.setup(cu);

Could you try to rewrite to testcase to avoid the usage of these static methods? (I don't know if it's possible, I don't have the code in front of me).

@jlerbsc jlerbsc merged commit 9ea19fc into javaparser:master Oct 18, 2020
@jlerbsc jlerbsc deleted the issue-1793 branch October 18, 2020 15:52
@MysterAitch MysterAitch added this to the next release milestone Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloning problems with LexicalPreservingPrinter (using 3.6.18)
3 participants