Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for v0.5 #30

Open
phemartin opened this issue Dec 11, 2019 · 10 comments
Open

Support for v0.5 #30

phemartin opened this issue Dec 11, 2019 · 10 comments

Comments

@phemartin
Copy link

Is there going to be an upgrade to slate v0.5? Really hoping so. Cheers

@mmdonaldson
Copy link

@phelipe3 still unclear to me how stable 0.5 is. Seems like Ian is rapidly iterating on it.

@phemartin
Copy link
Author

phemartin commented Jan 9, 2020

I agree. Seams to be more stable nowadays. Any update?

My current setup really depends on this plugin so I'll be waiting for it. I can also help with the move as well. :)

@mmdonaldson
Copy link

@phelipe3 if you have the time, maybe make the PR? How big of a job do you reckon it is?

@jasonphillips
Copy link
Owner

I'm looking at this in the coming days as I find time; does anyone happen to know of other mature plugins that have migrated to the new API? It would be helpful to use them as examples when I restructure the code.

@phemartin
Copy link
Author

phemartin commented Jan 13, 2020

@mmdonaldson I feel like I'm (currently) not that great of a programmer to issue a PM from scratch, but I definitely can help.

@jasonphillips The best plugin library I'am aware of is slate-plugins-next. (https://slate-plugins-next.netlify.com)

@jasonphillips
Copy link
Owner

@phelipe3

Thanks, slate-plugins-next looks very well structured, I can use that as a clean reference.

@jasonphillips
Copy link
Owner

Update: I'm still a bit torn as to how best to proceed with this library, given the discussion here:

ianstormtaylor/slate#3222

slate-plugins-next is a smart approach, but builds its own custom plugins logic on top of slate, and I prefer ideally to have slate's core as my only assumption here. So I could either follow that secondary plugins approach--and wed this library to a strategy that is one step removed from slate, and might break since it's not part of slate's internal assumptions--or turn this library into a set of smaller components that you hook into your slate instance somewhat manually, since the concept of a single "plugin" enclosing many changes (schema, key listeners, etc) is no longer part of slate's design.

@samlevin
Copy link

@jasonphillips what are you leaning towards? 0.5 fixes some long standing formatting bugs (worth upgrading for) and we also depend on slate-deep-table

@mmdonaldson
Copy link

FYI we are beginning the upgrade this week

@rnnyrk
Copy link

rnnyrk commented Feb 2, 2021

Is this already supported yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants