Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in .travis.yml #2856

Merged
merged 1 commit into from
Jun 15, 2020
Merged

fix: typo in .travis.yml #2856

merged 1 commit into from
Jun 15, 2020

Conversation

dominykas
Copy link
Contributor

@dominykas dominykas commented Jun 15, 2020

When I pass the current version through js-yaml, it tells me that the whitespace there is unexpected.

Could this be why the CI no longer works?

Then again, this might just need a migration to travis-ci.com, etc

When I pass the current version through js-yaml, it tells me that the whitespace there is unexpected.

Could this be why the CI no longer works?
@jgonggrijp
Copy link
Collaborator

Thanks for the fix, @dominykas!

Also thanks for the tip of migrating to travis-ci.com, I didn't think of that. From what I can find about it, however, it doesn't seem to be necessary; travis-ci.org is also still operational.

After some more research, I think your patch might very well be sufficient. The last commit for which Travis still worked was 1dfec11 (31. May 2018). The commit directly after that, 2e57316, introduced the misindentation by incorrectly uncommenting the lines in question.

@jgonggrijp jgonggrijp merged commit 3236023 into jashkenas:master Jun 15, 2020
@jgonggrijp jgonggrijp mentioned this pull request Jun 15, 2020
@dominykas dominykas deleted the patch-1 branch June 15, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants