Use npx for local browser testing #2828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When testing on a different machine, I found out that Karma cannot reliably find PhantomJS when following this approach. It happened to work on the machine where I created this PR because I already had a global installation of PhantomJS. I'm withdrawing the PR for this reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the
test-browserscript to usenpx. This preventsnpmfrom messing up thepackage.jsonandpackage-lock.jsonwhen younpm run test-browser.To be on the safe side, I copied the old version of the command to
test-browser-cifor the Travis build.@jashkenas FYI. I'm going to submit a bunch of small PRs in parallel to #2826. Please don't worry about the order, I'll fix any merge conflicts in #2826 if the need arises.