Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Travis build #2847

Closed
jgonggrijp opened this issue May 6, 2020 · 4 comments · Fixed by #2857
Closed

Fix the Travis build #2847

jgonggrijp opened this issue May 6, 2020 · 4 comments · Fixed by #2857

Comments

@jgonggrijp
Copy link
Collaborator

Preferably using GitHub Actions. See discussion in #2740.

@jgonggrijp
Copy link
Collaborator Author

@jashkenas We just got a patch by @dominykas that fixed an inconspicuous indentation mistake in the .travis.yml. I suspect this is the reason why Travis stopped working in 2018 (see #2856 (comment)). However, it appears that fixing the indentation is not sufficient to re-activate the repository; if I try to trigger a custom build on travis-ci.org, it still tells me that the repository is not active.

Would you mind a quick try whether you can activate the repository on travis-ci.org? I cannot do this on your behalf. With some luck, re-activating is all that is left to be done to get CI working again.

@jashkenas
Copy link
Owner

Sure thing. I’ve logged in and reactivated the repository on Travis.

@jashkenas jashkenas removed their assignment Jun 15, 2020
@jgonggrijp
Copy link
Collaborator Author

Thanks @jashkenas! I was able to trigger a custom build. It failed, but hopefully at least we now have any CI at all. After I'm done with #2849, I'll see whether I can fix the build.

Keeping this open until I'm sure the build triggers automatically.

@jgonggrijp
Copy link
Collaborator Author

I pushed a bunch of new commits to #2849 and Travis automatically started a new build, so it appears we'll have CI again. The build is however consistently failing over something futile, so keeping this open and changing the title to remind myself that there is still something to be done.

@jgonggrijp jgonggrijp changed the title Enable CI again Fix the Travis build Jun 19, 2020
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Jun 22, 2020
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Jun 27, 2020
npx rollup@latest produces Rollup version 2 nowadays, which is
incompatible with Node.js <10.
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Jun 27, 2020
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Jun 27, 2020
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Jun 27, 2020
@jgonggrijp jgonggrijp mentioned this issue Jun 27, 2020
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Jun 27, 2020
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Jun 27, 2020
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Jun 27, 2020
npx rollup@latest produces Rollup version 2 nowadays, which is
incompatible with Node.js <10.
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants