Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sauce Labs testing of pull requests? #2085

Closed
cvrebert opened this issue Feb 25, 2015 · 5 comments
Closed

Sauce Labs testing of pull requests? #2085

cvrebert opened this issue Feb 25, 2015 · 5 comments
Labels
test

Comments

@cvrebert
Copy link

Related to #2059, I'm wondering if there'd be any interest in running Sauce Labs real-browser JS tests on pull requests too? Over at Bootstrap, we're using Savage to accomplish this. (To see it in action, look at https://github.com/twbs-savage?tab=activity)
If there's interest, I'd be happy to help with the setup of a Savage instance for Underscore.
@megawac
Copy link
Collaborator

megawac commented Feb 25, 2015

Pinged you on gitter @cvrebert

@cvrebert
Copy link
Author

(Responded & had positive-sounding conversation on gitter.)

megawac referenced this issue in jashkenas/backbone Mar 3, 2015
@megawac
Encrypt keys
173d519
@megawac megawac mentioned this issue Mar 16, 2015
Merged
@jdalton
Copy link
Contributor

jdalton commented Aug 19, 2015

It seems like a lot of complexity for little gain as the cross browser issues are pretty well known in Underscore.

@jgonggrijp
Copy link
Collaborator

This may or may not become interesting again after #2847.

@jgonggrijp
Copy link
Collaborator

jgonggrijp commented Sep 25, 2020 •
edited
Loading

It's enabled now, but not working correctly. Continuing this in #2879.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdalton @cvrebert @jgonggrijp @megawac