Decouple --require from individual file compilations #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2011 14:20
This change allows files to be `--require`d before entering the REPL. It's also an opimization, since files are `--require`d only once, rather than being required again every time a file is compiled. A secondary change is that `module.filename` is temporarily modified. This is somewhat less aesthetically appealing than the old approach of using fs.realpathSync, but it allows you to run `coffee -r ./foo` rather than having to write `coffee -r ./foo.coffee`, since Node does not accept absolute paths without a file extension.
|
Also see my patch here for issue 1035, which this stemmed from. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
coffee -r "./foo.coffee"(in conjunction with-eor-c) willrequirefoo.coffee each time a file is compiled. In addition to the obvious inefficiency, there's a loss of functionality: You can't use the flag to require a file before entering the REPL.This patch fixes that;
coffee -r "./foo.coffee"now requiresfoo.coffeeand then enters the REPL. It also (temporarily) changesmodule.filenamebefore doing therequire; it feels a little kludgy, but it means that you can writeinstead of having to specify
./ext.coffeeor./ext.js, thus better mirroring therequiresyntax.