ToDo List #233

jarun · 2017-11-11T07:50:28Z

Continued from #174.

Notes

The list below is a growing one. While suggesting new features please consider contributing to Buku. The code is intentionally kept simple and easy to understand with comments. We'll be happy to assist any new contributor. We need your help!

Some of the fresh-baked features may not have been released yet. Grab the master branch for those.

Identified tasks

The text was updated successfully, but these errors were encountered:

QiangF · 2017-12-26T08:52:00Z

Since importing from different sources would inevitably introduce many duplications, a method of merging duplicated urls is crucial, I would suggest to pick the shortest title, and merge the tags.

jarun · 2017-12-26T08:53:46Z

Are you interested in implementing the feature?

QiangF · 2017-12-26T09:06:50Z

Yes, I will try, I have only very little knowledge of python and know nothing about sql.

jarun · 2017-12-26T10:01:19Z

I'm afraid at this stage of the project we need a little more experienced hands. BTW, Buku doesn't store duplicate URLs. So the first URL and associated data would be stored, rest would be discarded. I've thought about merging earlier but then, as long as the URL is in (and the user thought at some point the entry is complete with the first set of data) I think we are reasonably safe.

flashus · 2018-01-25T04:37:28Z

I think storing bookmark save date would be nice.

putsan · 2018-01-25T10:40:29Z

@flashus commented on 25 січ. 2018, 06:37 GMT+2:

I think storing bookmark save date would be nice.

So I think it may be necessary for me too

rachmadaniHaryono · 2018-01-25T11:08:56Z

@flashus , @putsan

Hi, please read the project policy:

no history, obsolete records, usage analytics or homing.

see also #103

jpdasma · 2018-01-29T03:28:25Z

Hello, I saw your thread here.
https://www.reddit.com/r/archlinux/comments/7tk50u/need_aur_maintainer/

I could volunteer for maintaining the AUR package, I have some experience in creating Fedora and Debian package. I might also look at the code sometime and contribute (currently using Python for work)

jarun · 2018-01-29T12:04:47Z

That's great! Can you please share your AUR username so I can add you as a maintainer?

putsan · 2018-01-29T12:07:27Z

Someone can make a package for Solus Os?

jarun · 2018-01-29T12:17:37Z

@putsan please contact the Solus OS team to add Buku to their repository. And probably some more of my utilities ;).

jarun · 2018-01-30T04:32:46Z

@jpdasma can you please share your AUR username?

jarun · 2018-01-30T04:33:55Z

@rachmadaniHaryono would it be possible for you to take care of the PyPi update? I am not expecting a next release of Buku soon.

jpdasma · 2018-01-30T05:43:54Z

Hello, although I have experience in creating Fedora and Debian packages due to work related reasons, I have minimal experience in creating an AUR package (thus still no AUR username). Is it okay if I could still maintain it? I'll try creating an AUR account later today.

jpdasma · 2018-01-30T05:46:18Z

Hello, I have created an AUR account with usernamen jpdasma. I'm willing to be the maintainer for this if you are okay with a maintainer with little experience with regards to AUR :-)

rachmadaniHaryono · 2018-01-30T08:43:59Z

@jarun , i will try it on the next release. ping me when new release is finished

jarun · 2018-01-30T13:22:50Z

@jpdasma that should be fine. There's one change in the last release of Buku you should be aware of - you can remove python-requests from the list of dependencies.

I have added you as a co-maintainer on AUR. Welcome!

jarun · 2018-01-30T13:23:28Z

@rachmadaniHaryono we are not going to have a new release soon. The last release is not updated on PyPi yet.

jpdasma · 2018-01-31T01:45:31Z

@jarun I'll take note of that

I will also try publishing an update to the AUR later today.

jarun · 2018-01-31T04:54:30Z

@jpdasma that's awesome!

rachmadaniHaryono · 2018-01-31T05:56:18Z

@jarun

it seems i can't upload to pypi.

Upload failed (403): The user 'rachmadaniHaryono' is not allowed to upload to project 'buku'. See https://pypi.org/help#project-name for more information.
error: Upload failed (403): The user 'rachmadaniHaryono' is not allowed to upload to project 'buku'. See https://pypi.org/help#project-name for more information.

based on error, i need to get permission to upload it

so i look at the pypi page and trying to fix the page.
- first i use pypandoc to convert readme.md (https://stackoverflow.com/a/26737672/1766261)
- write the converted text to readme.rst and check it with rstcheck. i found out that:
  - these example 336. DuckDuckGo > https://ddg.gg and 336. DDG (L) > https://ddg.gg # privacy,search engine Note that URL must precede tags. are recognized as enumerated list by rst.
  - between first and second example need newline.
- those method above still didn't work, so as a test i remove the raw block.
the result https://test.pypi.org/project/buku/3.6.post8/
here come the new problem, how do we maintain it?
- remove the html part from readme.md. hopefully pypandoc can successfully convert it directly.
- maintain separate branch. this branch contain readme.rst which should be generated by pypandoc and applied the above [pypi page fix] manually

for the second method i hope it can successfully upload to pypi. on these test i have to rename the version multiple time. i added 'postn' suffix so i can upload it to test.pypi (based on this https://stackoverflow.com/a/13919964/1766261)

jarun · 2018-01-31T06:15:00Z

I have added you for the permission issues. Try once more. For the other part, do as you see fit.

rachmadaniHaryono · 2018-01-31T06:25:47Z

https://pypi.python.org/pypi/buku it is done

my browser load the page stop few seconds between these lines

        w [editor|id]          edit and add or update a bookmark
        ?                      show this help

maybe rst need few time to process ? show this help due to leading question mark

e: and i have no idea why the test.pypi format the readme back to raw rst

e2:https://github.com/rachmadaniHaryono/Buku/tree/feature/release-branch

e3: guide for uploading to pypi

register to pypi and test.pypi
create ~/.pypirc and fill it with your config (example below)
remove readme.rst if exist
generate readme.rst
applied following fix:
5.1 check any text that maybe recognized as enumerated list
5.2 newline between example section
upload first to test.pypi. command: python3 setup.py sdist upload -r pypitest
if upload success but result is not as intended, change the version with postn-suffix format. fix the program and go to number 6.
if upload sucsess and result is as intended:
7.1 check the program version. maybe rolled it back to original if possible
7.2 upload it to pypi. command: python3 setup.py sdist upload -r pypi

code to generate readme.rst, require pypandoc from pip and pandoc e.g. from ubuntu repo
(note that everytime setup.py executed it will generate readme.rst if not exist)

import pypandoc
long_description = pypandoc.convert_file('README.md', 'rst')
with open("README.rst", "w") as f:
    f.write(long_description)

example pypirc

[distutils]
index-servers =
  pypi
  pypitest

[pypi]
repository=https://pypi.python.org/pypi
username=RachmadaniHaryono
password=<password>

[pypitest]
repository=https://test.pypi.org/legacy/
username=rachmadaniHaryono
password=<password>

jarun · 2018-01-31T06:31:38Z

No issues with loading here! 👍
Where's the test.pypi file? Link please.

rachmadaniHaryono · 2018-01-31T06:48:50Z

add the doc see the 3th edit of my comment above

Where's the test.pypi file? Link please

you mean this ?

https://test-files.pythonhosted.org/packages/c3/74/c4b3cedaf04e262d9a78bf1d291c08ddea0882d336c19baf5e2d78abe691/buku-3.6.post8.tar.gz

on this page https://test.pypi.org/project/buku/3.6.post8/#files

it is basically this commit 83165e2

jarun · 2018-01-31T08:14:14Z

Ignore ;). As long as users can download the package we are good!

jarun · 2018-02-06T14:51:53Z

@mosegontar would you have the time to try the first item? I added it today.

mosegontar · 2018-02-06T23:41:20Z

@jarun,hi! thanks for pinging me. I'll have to do some research how to do this in SQL and modify the search queries, but I can take a crack at it this weekend, if that's okay.

To clarify the task:
If bookmarkA has the title "title1" and the tag "tagA", and bookmarkB has the title "title2" and tag "tagA", and we run buku -s tagA title2, both bookmarks should be returned in the results (current behavior) and bookmarkB should appear before bookmarkA in the results (new behavior).

And this should apply to all searches with 'any' logic (but, I assume, not 'all' logic)?

jarun · 2018-02-07T02:38:50Z

Yes, your understanding is correct. 👍
Also, we are using sqlite in Buku so research based on sqlite.

mosegontar · 2018-02-11T21:20:11Z

@jarun, just an update. I finally figured out the query:

SELECT id, url, metadata, tags, desc,
    CASE
        WHEN (tags REGEXP 'python' OR URL REGEXP 'python' OR metadata REGEXP 'python' OR desc REGEXP 'python')
            THEN 1 ELSE 0 END
        + CASE WHEN (tags REGEXP 'ruby' OR URL REGEXP 'ruby' OR metadata REGEXP 'ruby' OR desc REGEXP 'ruby')
            THEN 1 ELSE 0 END
        + CASE WHEN (tags REGEXP 'programming' OR URL REGEXP 'programming' OR metadata REGEXP 'programming' OR desc REGEXP 'programming')
            THEN 1 ELSE 0
    END score
FROM bookmarks
WHERE score > 0
ORDER BY
score DESC;

Will hopefully be able to make a PR this week, but if you're in a hurry I am happy to hand it off too.

jarun · 2018-02-11T22:54:58Z

Please take your time.

UplandsDynamic · 2018-02-24T01:43:44Z

@jarun I've created a snap package for this, for easy installation across my local Linux systems. It's very easy to maintain (when the snap is installed it pulls directly from your latest release, installs all the dependences etc).

Would you be interested in publishing the snap in the Ubuntu snap store? It'd make installing over most popular Linux distros as easy as 'snap install buku'. If you'd like me to assist in publishing the snap, or even maintain the published snap on your behalf, please let me know.

jarun · 2018-02-24T03:07:42Z

I do not maintain any downstream packages. If you can maintin I have no issues.

Please ensure the changes in the codebase are minimal.

Generally I discourage snaps but Buku has a few deps so we can have it.

UplandsDynamic · 2018-02-24T20:32:26Z

@jarun Thank you for permitting your application to be snapped, much appreciated. The snap would build directly from your latest released version, so no changes to your codebase at all. I've got the ball rolling - it's now pushed to a buku repository in the Ubuntu snap store and should be published soon.

rachmadaniHaryono · 2018-02-25T03:06:16Z

@jarun i create https://github.com/jarun/Buku/wiki/Upload-to-pypi, so anyone who want to upload the program to pypi can look at that instead searching in todo list thread

jarun · 2018-02-25T04:04:45Z

thanks @Aninstance and @rachmadaniHaryono!

jarun · 2018-03-12T04:07:39Z

@mosegontar would you have the time to work on the first item (paging support)?

mosegontar · 2018-03-16T01:41:36Z

@jarun hi! my apologies for the delay. I'm pretty tied up lately, so I don't think I'd have time to work on it, but thanks for checking with me.

jarun · 2018-03-16T03:08:17Z

@mosegontar Hey no problem!

jarun · 2018-03-16T14:59:27Z

Rolled at #251.

jarun mentioned this issue Nov 11, 2017

ToDo List #174

Closed

42 tasks

jarun added the help wanted label Nov 11, 2017

mosegontar closed this as completed Mar 16, 2018

jarun mentioned this issue Mar 16, 2018

ToDo List #251

Closed

49 tasks

github-actions bot locked and limited conversation to collaborators Jun 16, 2020

ToDo List #233

ToDo List #233

Comments

jarun commented Nov 11, 2017 • edited Loading

Notes

Identified tasks

QiangF commented Dec 26, 2017

jarun commented Dec 26, 2017

QiangF commented Dec 26, 2017

jarun commented Dec 26, 2017 • edited Loading

flashus commented Jan 25, 2018

putsan commented Jan 25, 2018

rachmadaniHaryono commented Jan 25, 2018 • edited Loading

jpdasma commented Jan 29, 2018

jarun commented Jan 29, 2018

putsan commented Jan 29, 2018

jarun commented Jan 29, 2018

jarun commented Jan 30, 2018

jarun commented Jan 30, 2018

jpdasma commented Jan 30, 2018

jpdasma commented Jan 30, 2018

rachmadaniHaryono commented Jan 30, 2018

jarun commented Jan 30, 2018

jarun commented Jan 30, 2018

jpdasma commented Jan 31, 2018 • edited Loading

jarun commented Jan 31, 2018

rachmadaniHaryono commented Jan 31, 2018 • edited Loading

jarun commented Jan 31, 2018

rachmadaniHaryono commented Jan 31, 2018 • edited Loading

jarun commented Jan 31, 2018

rachmadaniHaryono commented Jan 31, 2018 • edited Loading

jarun commented Jan 31, 2018

jarun commented Feb 6, 2018

mosegontar commented Feb 6, 2018

jarun commented Feb 7, 2018

mosegontar commented Feb 11, 2018

jarun commented Feb 11, 2018

UplandsDynamic commented Feb 24, 2018

jarun commented Feb 24, 2018

UplandsDynamic commented Feb 24, 2018

rachmadaniHaryono commented Feb 25, 2018

jarun commented Feb 25, 2018

jarun commented Mar 12, 2018

mosegontar commented Mar 16, 2018

jarun commented Mar 16, 2018

jarun commented Mar 16, 2018

jarun commented Nov 11, 2017 •

edited

Loading

jarun commented Dec 26, 2017 •

edited

Loading

rachmadaniHaryono commented Jan 25, 2018 •

edited

Loading

jpdasma commented Jan 31, 2018 •

edited

Loading

rachmadaniHaryono commented Jan 31, 2018 •

edited

Loading

rachmadaniHaryono commented Jan 31, 2018 •

edited

Loading

rachmadaniHaryono commented Jan 31, 2018 •

edited

Loading