Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bundle size GH action to all templates #841

Closed
jaredpalmer opened this issue Aug 28, 2020 · 1 comment · Fixed by #705
Closed

Add bundle size GH action to all templates #841

jaredpalmer opened this issue Aug 28, 2020 · 1 comment · Fixed by #705
Labels
kind: feature New feature or request problem: removed issue template OP removed the issue template without good cause problem: stale Issue has not been responded to in some time scope: templates Related to an init template, not necessarily to core (but could influence core) solution: duplicate This issue or pull request already exists solution: workaround available There is a workaround available for this issue
Milestone
v0.14.0 - Dep Upg...

Comments

@jaredpalmer
Copy link
Owner

Seems like everyone will want this https://github.com/preactjs/compressed-size-action
@agilgur5 agilgur5 added solution: duplicate This issue or pull request already exists kind: feature New feature or request problem: removed issue template OP removed the issue template without good cause labels Aug 29, 2020
@agilgur5
Copy link
Collaborator

agilgur5 commented Aug 29, 2020 •
edited
Loading

Duplicate of #496 / #741. And there's already a PR #705 that uses size-limit and adds commands and a GH action to the templates and has gone through some iterations (probably just about ready to merge).

@jaredpalmer would greatly appreciate if you could search the issues and fill out the issue template and not make exceptions. There's already a problem with people removing the template and filing duplicates and I don't think this acts as a good role model.

@agilgur5 agilgur5 changed the title Add Preact’s bundle size GH action to all templates Add bundle size GH action to all templates Aug 29, 2020
@agilgur5 agilgur5 linked a pull request Aug 29, 2020 that will close this issue
Add size-limit bundle size analysis tool #705
Merged
@agilgur5 agilgur5 added scope: templates Related to an init template, not necessarily to core (but could influence core) solution: workaround available There is a workaround available for this issue labels Sep 7, 2020
@agilgur5 agilgur5 mentioned this issue Oct 14, 2020
Merged
@agilgur5 agilgur5 added the problem: stale Issue has not been responded to in some time label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: feature New feature or request problem: removed issue template OP removed the issue template without good cause problem: stale Issue has not been responded to in some time scope: templates Related to an init template, not necessarily to core (but could influence core) solution: duplicate This issue or pull request already exists solution: workaround available There is a workaround available for this issue
Projects
None yet
Milestone
v0.14.0 - Dep Upgrades - Jest 25 + No...
Development

Successfully merging a pull request may close this issue.

Add size-limit bundle size analysis tool andresz1/tsdx
2 participants
@jaredpalmer @agilgur5