HA Sync fields cannot be set via /api/v1/system/api

[jaredhendrickson13]

Describe the bug
The hasync_hosts, hasync_username and hasync_password fields are not being set during PUT requests to /api/v1/system/api. This is because the field validation is not using isset($this->validated_data["hasync"]) to trigger the logic and is instead using $this->validated_data["hasync"] which never triggers because pfSense stores the value as an empty string.

To Reproduce

curl -s -k -u admin:pfsense -X PUT https://localhost/api/v1/system/api -d '{"hasync": true, "hasync_hosts": ["127.0.0.1"], "hasync_username": "admin", "hasync_password": "pfsense"}'

Expected behavior
Whenever hasync is set to true, the hasync_hosts, hasync_username and hasync_password fields should become required. Instead, they are being skipped entirely.

pfSense Version & Package Version:

• pfSense Version: All
• Package Version v1.5.0 and earlier

Affected Endpoints:

• /api/v1/system/api