Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication in typing backports? #3

Closed
emmatyping opened this issue Oct 12, 2017 · 7 comments
Closed

Remove duplication in typing backports? #3

emmatyping opened this issue Oct 12, 2017 · 7 comments

Comments

@emmatyping
Copy link

Hello,

I am a collaborator on mypy. We recently came across someone who was using this package with mypy, and it was causing issues. The problem was trying to use backports.typing.{type} as a valid type. Since there is already the typing module and backport, I was interested in the possibility of removing this package from PyPI, and pointing to the official backport when the user tries to install it. That way confusion is avoided and everyone can use the official typing. You can see the context and the issue here. Thanks!

Ethan

@jaraco
Copy link
Owner

jaraco commented Nov 12, 2017

It's kinda strange that typing exists. It masks a stdlib module, so if you install it on Python 3, you still get the stdlib version when import typing.

But if that's the recommended way to provide cross-version compatibility, then there's no need for backports. So be it.

@jaraco
Copy link
Owner

jaraco commented Nov 12, 2017

I've removed it from PyPI.

@jaraco jaraco closed this as completed in e5187e3 Nov 12, 2017
@enkidulan
Copy link

enkidulan commented Dec 4, 2017

@jaraco removing backports.typing from pypi have broken my builds. You could release a new version with a deprecation warning and deprecate this package without removing it from pypi.

@emmatyping
Copy link
Author

@enkidulan, you should just move to using typing. The typing module has everything you need.

@enkidulan
Copy link

enkidulan commented Dec 5, 2017

@ethanhs I'm using typing at the current project and will use it for future projects as well. But try to think about removing distribution from pypi in context of supporting legacy code or projects that are not in active development state. There are some number of packages that have backports.typing as dependency and recently they all become impossible to install... Probably most ppl will resolve this issue by creating an internal release of backports.typing instead of migrating all to typing, especially in case of using 3rd party libraries that are dependent on backports.typing.

I don't really see why removing backports.typing from pypi was necessary...

@jaraco
Copy link
Owner

jaraco commented Dec 5, 2017

Since gvr requested it be removed, I found it difficult to argue.

I presume by now the damage is done, but if you wish to re-publish backports.typing (perhaps with the deprecation warning), feel free to register and upload the dists. If you would like me to hand over this repo to your account, I'm happy to do that too.

@enkidulan
Copy link

That is scary :)

I'm willing to contribute to making deprecation procedure of backports.typing less painful if there will be any demand for it. So far it seems that no one cares...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants