Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-square images are squished #278

Closed
TrevinAvery opened this issue Jul 9, 2021 · 1 comment Β· Fixed by #331
Closed

non-square images are squished #278

TrevinAvery opened this issue Jul 9, 2021 · 1 comment Β· Fixed by #331
Labels

Comments

@TrevinAvery
Copy link

Current behaviour πŸ’£

If your source image is not square, it will be squished to become square.

Expected behaviour β˜€οΈ

For non-square images, it would be better to simply add transparent spacing so the content of the image does not change. Maybe even clip to the actual content of the image first, in case there are transparent borders.

Reproduction Example πŸ‘Ύ

Just use an image that is not square.

Environment πŸ–₯

Node.js v16.4.2
darwin 18.7.0

β”œβ”€β”¬ @vue/cli-plugin-babel@5.0.0-beta.2
β”‚ β”œβ”€β”¬ babel-loader@8.2.2
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ thread-loader@3.0.4
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ └── webpack@5.44.0
β”œβ”€β”¬ @vue/cli-plugin-eslint@5.0.0-beta.2
β”‚ β”œβ”€β”¬ eslint-webpack-plugin@2.4.3
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ └── webpack@5.44.0 deduped
β”œβ”€β”¬ @vue/cli-service@5.0.0-beta.2
β”‚ β”œβ”€β”¬ @soda/friendly-errors-webpack-plugin@1.8.0
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ @vue/vue-loader-v15@npm:vue-loader@15.9.7
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ cache-loader@4.1.0
β”‚ β”‚ └── webpack@5.44.0 deduped invalid
β”‚ β”œβ”€β”¬ copy-webpack-plugin@8.1.1
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ css-loader@5.2.6
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ css-minimizer-webpack-plugin@2.0.0
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ file-loader@6.2.0
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ html-webpack-plugin@5.3.2
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ mini-css-extract-plugin@1.6.2
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ postcss-loader@5.3.0
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ terser-webpack-plugin@5.1.4
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ url-loader@4.1.1
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”œβ”€β”¬ webpack-dev-server@3.11.2
β”‚ β”‚ β”œβ”€β”¬ webpack-dev-middleware@3.7.3
β”‚ β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ β”‚ └── webpack@5.44.0 deduped
β”‚ └── webpack@5.44.0 deduped
β”œβ”€β”¬ favicons-webpack-plugin@5.0.2
β”‚ β”œβ”€β”€ favicons@6.2.2 deduped
β”‚ β”œβ”€β”€ html-webpack-plugin@5.3.2 deduped
β”‚ └── webpack@5.44.0 deduped
β”œβ”€β”€ favicons@6.2.2
β”œβ”€β”¬ responsive-loader@2.3.0
β”‚ └── webpack@5.44.0 deduped
β”œβ”€β”¬ sass-loader@10.2.0
β”‚ └── webpack@5.44.0 deduped
β”œβ”€β”¬ vue-cli-plugin-vuetify@2.4.1
β”‚ └─┬ null-loader@3.0.0
β”‚   └─┬ webpack@4.46.0
β”‚     └─┬ terser-webpack-plugin@1.4.5
β”‚       └── webpack@4.46.0 deduped
└─┬ vuetify-loader@1.7.2
  └── webpack@5.44.0 deduped
@stale
Copy link

stale bot commented Apr 18, 2022

This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant