Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next-release] Translated copyright text not showing #914

Closed
henkdegroot opened this issue Mar 28, 2023 · 4 comments
Closed

[Next-release] Translated copyright text not showing #914

henkdegroot opened this issue Mar 28, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@henkdegroot
Copy link
Contributor

URL
http://127.0.0.1:4000/nl/

Describe the bug
With NL selected as the site language, the text in the navigation and footer section are not showing in Dutch but always show in English.

Navigation section:
image

Footer section:
image

@henkdegroot henkdegroot added the bug Something isn't working label Mar 28, 2023
@henkdegroot
Copy link
Contributor Author

henkdegroot commented Mar 28, 2023

I found the cause of this issue and this can be fixed by updating the _po4a-tools/po4a-create-all-targets.sh script.

image

The highlighted section needs to be extended to include the reference to the copyright file.

image

Not sure if the copyright file also needs be excluded from the threshold calculation.

@ignotus666
Copy link
Contributor

@henkdegroot feel free to make a PR with the fix (here and elsewhere) - this week I'm going to be very pressed for time...

I'm not sure about excluding it from the threshold -I'm inclined to think it doesn't need to be- but maybe a quick test to confirm it would be best.

@henkdegroot
Copy link
Contributor Author

Can this issue be linked to #917 ?

@ignotus666
Copy link
Contributor

Yes, this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants