Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height issue when all values are zero #86

Closed
pptyasar opened this issue Jun 25, 2018 · 3 comments
Closed

Height issue when all values are zero #86

pptyasar opened this issue Jun 25, 2018 · 3 comments
Labels

Comments

@pptyasar
Copy link

pptyasar commented Jun 25, 2018

When dynamic height is set and all values are zero than funnel is collapsed.

https://jsfiddle.net/wtsk2L97/485/

As request
#70 (comment)

@jakezatecky
Copy link
Owner

@pptyasar That issue is not nearly as pronounced in the latest version of the library. It appears your example is using v0.7.5 whereas the latest is v1.1.1. See the fork I created of that which shows that a funnel is rendered, although it does not fully respect the height:

https://jsfiddle.net/s4qjuxry/2/

I will be adding a fix that makes the funnel take up the remaining space in the instance that all values are zero.

@jakezatecky
Copy link
Owner

This should now be fixed. See https://jsfiddle.net/s4qjuxry/4/.

@pptyasar
Copy link
Author

@jakezatecky thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants