-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Query to both Document and Column communication API #90
Comments
@amoscatelli does it make your life easier? |
It would be interesting to be able to add indices in order to optimize the query. |
Not sure regarding adding indexes as they might take hours to get built, but suggesting the index is definitely a good thing.Many nosql databases tend to have a rule-based optimizer instead of a cost-based one. Even on relational, if the statistics are not updated, it might lead to the query planner to pick the wrong index. |
@otaviojava From my experience, most the complex queries have 3 things:
|
@otaviojava it would be great if this builder could handle lambda expressions like FluentMongo does |
further, intersect and union queries? how will those be handled? is that part of the spec as well for consideration? |
@deniswsrosa I'll keep my eyes on it as the next step. |
Hey @somayaj We don't support it yet; we're making baby-step progress in the specification. It is not yet, but we must have support for it. |
@boaglio, thank you for the suggestion; we'll look into it. |
@otaviojava yea, it looks great. I am going to use this inside DocumentTemplate (mapping layer) to map Criteria API into low level communication layer objects. Who is going to work on this ? p.s. I could work on this too. Just let me know. |
@amoscatelli I'll work on this and then open a PR to review. I will send a PR tonight. |
@amoscatelli I finished the API and the documentation it left the implementation: |
@otaviojava the implementation is ready ? do you need help ? |
I find it very suitable. Offering alternatives makes it easier to use. |
Currently, we have query support using a fluent API to both select and delete, but it has several limitations, such as evolute complex conditions.
The proposal is to add a
builder
method in the Query interfaces such as DocumentQuery, ColumnQuery, etc. This way, it will create more complex queries easier without using the fluent API.Furthermore, it will make it easier to implement the Criteria API.
The text was updated successfully, but these errors were encountered: