Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find operations in jaeger-ui, if there is '/' char in serviceName #586

Closed
niuhf0452 opened this issue Dec 6, 2017 · 7 comments
Closed

Comments

@niuhf0452
Copy link

image

@yurishkuro
Copy link
Member

good catch.

cc @tiffon

@yurishkuro
Copy link
Member

Re-booked as a UI issue jaegertracing/jaeger-ui#138

@tiffon
Copy link
Member

tiffon commented Mar 12, 2018

@yurishkuro looks like merging jaegertracing/jaeger-ui#140 surfaced an issue in jaeger-query.

I ran the hotrod demo with the service names to have jaeger/ prepended. The request to get operations for jaeger/customer is GET for the following URL:

http://localhost:16686/api/services/jaeger%2Fcustomer/operations

The query service responds with the index.html.

Seems like this ticket should be reopened.

@yurishkuro
Copy link
Member

arrrg... Should we just switch to the ?service= API?

@yurishkuro
Copy link
Member

@tiffon we may have to switch the UI to /api/operations?service=, because I just ran a test (#736) and it doesn't look like Gorilla router we're using is able to deal with / in the middle of the parameter, even if it's url-encoded.

@tiffon
Copy link
Member

tiffon commented Mar 12, 2018

@yurishkuro I think Gorilla might have a facility for handling this (if I followed correctly):

API: http://www.gorillatoolkit.org/pkg/mux#Router.UseEncodedPath

Related ticket: gorilla/mux#77

Changes that are referenced:

@yurishkuro
Copy link
Member

true, I was able to fix the test, but I still think that we should do what we planned long time ago - only support /api/operations?service= API and remove all this duplicated / special-cased code from query service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants