Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin gRPC #1781

Closed
yurishkuro opened this issue Sep 7, 2019 · 6 comments
Closed

Unpin gRPC #1781

yurishkuro opened this issue Sep 7, 2019 · 6 comments

Comments

@yurishkuro
Copy link
Member

For some reason #1492 pinned gRPC to a specific release, we need to unpin it. It will require resolving these issues:

Detected staticcheck failures:
cmd/agent/app/reporter/grpc/builder.go:133:36: grpc.WithBalancerName is deprecated: use WithDefaultServiceConfig and WithDisableServiceConfig instead.  Will be removed in a future 1.x release.  (SA1019)
pkg/discovery/grpcresolver/grpc_resolver_test.go:146:78: grpc.WithBalancerName is deprecated: use WithDefaultServiceConfig and WithDisableServiceConfig instead.  Will be removed in a future 1.x release.  (SA1019)
make: *** [lint-staticcheck] Error 1
@guanw
Copy link
Contributor

guanw commented Sep 8, 2019

@yurishkuro I can work on this since I introduced WithBalancerName

@guanw
Copy link
Contributor

guanw commented Sep 8, 2019

WithDefaultServiceConfig introduces a json string serviceConfig that looks like this, should we also introduce a flag for this which defaults to {"loadBalancingPolicy":"round_robin"}

@guanw
Copy link
Contributor

guanw commented Sep 8, 2019

Also when I comment out override section for google.golang.org/grpc in toml file and do dep ensure -update google.golang.org/grpc, the following error shows (incomplete log):
image

Looks like @objectiser introduces the revision. Any idea we are pinning jaeger-client-go to 6733ee486c780528f2c8088305e16fdb685134c7 (Can we remove this constraint first)?

@yurishkuro
Copy link
Member Author

I already have a PR to remove client pin: #1780

@yurishkuro
Copy link
Member Author

WithDefaultServiceConfig introduces a json string serviceConfig

I assume json is an option, not a requirement, i.e. do we still have programmatic way to configure? I prefer we fix the main issue first, not introduce new configuration options.

@guanw
Copy link
Contributor

guanw commented Sep 9, 2019

@yurishkuro See grpc/grpc-go#3003, looks like that's the only recommended way. We can put a const serviceConfig = <service config json string> for now to avoid setting flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants