From 9f4e8f79ab184fbaa227787f9302d91f3f8feafc Mon Sep 17 00:00:00 2001 From: Mahad Zaryab <43658574+mahadzaryab1@users.noreply.github.com> Date: Thu, 24 Oct 2024 22:45:24 -0400 Subject: [PATCH] [fix][query] Correct query server legacy condition (#6120) ## Which problem is this PR solving? - Towards #6026 ## Description of the changes - Fixes an issue from https://github.com/jaegertracing/jaeger/pull/6055 where the condition for routing to the legacy implementation was accidentally flipped. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Mahad Zaryab --- cmd/query/app/server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/query/app/server.go b/cmd/query/app/server.go index aa4647590c7..a2c916149e0 100644 --- a/cmd/query/app/server.go +++ b/cmd/query/app/server.go @@ -82,7 +82,7 @@ func NewServer( } var grpcServer *grpc.Server - if separatePorts { + if !separatePorts { grpcServer, err = createGRPCServerLegacy(ctx, options, tm) } else { grpcServer, err = createGRPCServerOTEL(ctx, options, tm, telset)