From 615bf6656ad675d07c7f99fb61922c844a7d9b05 Mon Sep 17 00:00:00 2001 From: Tim Klever Date: Wed, 12 Aug 2020 02:06:29 -0700 Subject: [PATCH] clear console errors (proptype violations) from CLI output These tests, due to missing required props, were leaving console.error messages in the test run CLI output. It doesn't effect the tests, it doesn't cause any false positives or negatives, but it could be seen as a distraction seeing red output fly across the screen in an otherwise passing test. Signed-off-by: Tim Klever --- .../src/components/SearchTracePage/SearchForm.test.js | 1 + .../SearchTracePage/SearchResults/ResultItem.test.js | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js b/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js index 05865b757f..c5c5317235 100644 --- a/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js +++ b/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js @@ -56,6 +56,7 @@ const DATE_FORMAT = 'YYYY-MM-DD'; const TIME_FORMAT = 'HH:mm'; const defaultProps = { dataCenters: ['dc1'], + handleSubmit: () => {}, searchMaxLookback: { label: '2 Days', value: '2d', diff --git a/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.test.js b/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.test.js index c25130617a..2d03716c98 100644 --- a/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.test.js +++ b/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.test.js @@ -24,7 +24,7 @@ import transformTraceData from '../../../model/transform-trace-data'; const trace = transformTraceData(traceGenerator.trace({})); it(' should render base case correctly', () => { - const wrapper = shallow(); + const wrapper = shallow(); const numberOfSpanText = wrapper .find(`[data-test="${markers.NUM_SPANS}"]`) .first() @@ -36,7 +36,7 @@ it(' should render base case correctly', () => { }); it(' should not render any ServiceTags when there are no services', () => { - const wrapper = shallow(); + const wrapper = shallow(); const serviceTags = wrapper.find(`[data-test="${markers.SERVICE_TAGS}"]`).find(Tag); expect(serviceTags).toHaveLength(0); });