Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String tags are being interpreted as numbers #396

Closed
chopper-poet opened this issue Jun 21, 2019 · 3 comments · Fixed by #436
Closed

String tags are being interpreted as numbers #396

chopper-poet opened this issue Jun 21, 2019 · 3 comments · Fixed by #436

Comments

@chopper-poet
Copy link

hello,friend
two questions:

i write a tag like this
image

but jaeger-ui show error,like this
image

i write a tag like this
image

image

image

@yurishkuro yurishkuro changed the title jaeger-ui bug String tags are being interpreted as numbers Jun 23, 2019
@yurishkuro yurishkuro transferred this issue from jaegertracing/jaeger Jun 23, 2019
@pavolloffay
Copy link
Member

cc @tiffon

@tiffon tiffon added the bug label Jun 25, 2019
@tiffon
Copy link
Member

tiffon commented Jun 25, 2019

We try to JSON parse values so we can format JSON strings. Looks like we missed an edge case. We should probably limit attempting to parse values to when the value starts with either { or [.

function parseIfJson(value: any) {
try {
return JSON.parse(value);
// eslint-disable-next-line no-empty
} catch (_) {}
return value;
}

Thanks for filing this!

@Cekonieczny
Copy link

Hi, I have a similiar issue. Is there currently any workaround on that?
jaeger_string_to_number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants