diff --git a/src/components/TracePage/TraceTimelineViewer/ListView/index.js b/src/components/TracePage/TraceTimelineViewer/ListView/index.js index 587c45477f..8094a8839b 100644 --- a/src/components/TracePage/TraceTimelineViewer/ListView/index.js +++ b/src/components/TracePage/TraceTimelineViewer/ListView/index.js @@ -375,7 +375,7 @@ export default class ListView extends React.Component { const max = nodes.length; for (let i = 0; i < max; i++) { const node: HTMLElement = (nodes[i]: any); - // const itemKey = node.dataset.itemKey; + // use `.getAttribute(...)` instead of `.dataset` for jest / JSDOM const itemKey = node.getAttribute('data-item-key'); if (!itemKey) { // eslint-disable-next-line no-console diff --git a/src/components/TracePage/TraceTimelineViewer/ListView/index.test.js b/src/components/TracePage/TraceTimelineViewer/ListView/index.test.js index 07e56d3b88..8c5f5a43ff 100644 --- a/src/components/TracePage/TraceTimelineViewer/ListView/index.test.js +++ b/src/components/TracePage/TraceTimelineViewer/ListView/index.test.js @@ -134,7 +134,7 @@ describe('', () => { windowAddListenerSpy.mockRestore(); }); - it('adds the onScroll listener to the root HTML element after it mounts', () => { + it('adds the onScroll listener to the window element after the component mounts', () => { expect(windowAddListenerSpy).toHaveBeenCalled(); expect(windowAddListenerSpy).toHaveBeenLastCalledWith('scroll', instance._onScroll); });