diff --git a/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.js b/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.js index d8679c66df..6a83651db3 100644 --- a/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.js +++ b/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.js @@ -15,7 +15,7 @@ // limitations under the License. import * as React from 'react'; -import { Select } from 'antd'; +import { Button, Col, Select } from 'antd'; import { Field, reduxForm, formValueSelector } from 'redux-form'; import DiffSelection from './DiffSelection'; @@ -41,6 +41,7 @@ type SearchResultsProps = { hideGraph?: boolean, disableComparision?: boolean, loading: boolean, + onGoFullClicked: () => void, maxTraceDuration: number, skipMessage?: boolean, traces: TraceSummary[], @@ -110,7 +111,7 @@ export default class SearchResults extends React.PureComponent ); } - const { goToTrace, isEmbed, hideGraph, disableComparision, maxTraceDuration } = this.props; + const { goToTrace, isEmbed, hideGraph, disableComparision, onGoFullClicked, maxTraceDuration } = this.props; const cohortIds = new Set(diffCohort.map(datum => datum.id)); return (
@@ -134,6 +135,11 @@ export default class SearchResults extends React.PureComponent + {isEmbed && ( + + )}

{traces.length} Trace{traces.length > 1 && 's'}

diff --git a/packages/jaeger-ui/src/components/SearchTracePage/index.js b/packages/jaeger-ui/src/components/SearchTracePage/index.js index 1d595adb7c..90738b4268 100644 --- a/packages/jaeger-ui/src/components/SearchTracePage/index.js +++ b/packages/jaeger-ui/src/components/SearchTracePage/index.js @@ -13,7 +13,7 @@ // limitations under the License. import React, { Component } from 'react'; -import { Col, Row, Button } from 'antd'; +import { Col, Row } from 'antd'; import PropTypes from 'prop-types'; import queryString from 'query-string'; import { connect } from 'react-redux'; @@ -102,7 +102,6 @@ export class SearchTracePageImpl extends Component { )} - {isEmbed && } {showErrors && (

There was an error querying for traces:

@@ -118,6 +117,7 @@ export class SearchTracePageImpl extends Component { cohortRemoveTrace={cohortRemoveTrace} diffCohort={diffCohort} skipMessage={isHomepage} + onGoFullClicked={this.goFullView} traces={traceResults} isEmbed={isEmbed} hideGraph={hideGraph} diff --git a/packages/jaeger-ui/src/components/SearchTracePage/index.test.js b/packages/jaeger-ui/src/components/SearchTracePage/index.test.js index 64bfcebd82..904151dfa2 100644 --- a/packages/jaeger-ui/src/components/SearchTracePage/index.test.js +++ b/packages/jaeger-ui/src/components/SearchTracePage/index.test.js @@ -34,7 +34,6 @@ import { shallow, mount } from 'enzyme'; import store from 'store'; import { SearchTracePageImpl as SearchTracePage, mapStateToProps } from './index'; -import { Button } from 'antd'; import SearchForm from './SearchForm'; import LoadingIndicator from '../common/LoadingIndicator'; import { fetchedState } from '../../constants'; @@ -106,11 +105,6 @@ describe('', () => { expect(wrapper.find('.js-test-logo').length).toBe(1); }); - it('shows button with a link to the Search page if is embed', () => { - wrapper.setProps({ isEmbed: true }); - expect(wrapper.find(Button).length).toBe(1); - }); - it('hide SearchForm if is embed', () => { wrapper.setProps({ isEmbed: true }); expect(wrapper.find(SearchForm).length).toBe(0); diff --git a/packages/jaeger-ui/src/components/TracePage/TracePageHeader.js b/packages/jaeger-ui/src/components/TracePage/TracePageHeader.js index f308d852f0..f9a6d01d62 100644 --- a/packages/jaeger-ui/src/components/TracePage/TracePageHeader.js +++ b/packages/jaeger-ui/src/components/TracePage/TracePageHeader.js @@ -45,6 +45,9 @@ type TracePageHeaderProps = { resultCount: number, archiveButtonVisible: boolean, onArchiveClicked: () => void, + onGoBackClicked: () => void, + onGoFullViewClicked: () => void, + embed: boolean, // these props are used by the `HEADER_ITEMS` // eslint-disable-next-line react/no-unused-prop-types timestamp: number, @@ -104,6 +107,8 @@ export function TracePageHeaderFn(props: TracePageHeaderProps) { name, slimView, onSlimViewClicked, + onGoBackClicked, + onGoFullViewClicked, updateTextFilter, textFilter, prevResult, @@ -111,6 +116,7 @@ export function TracePageHeaderFn(props: TracePageHeaderProps) { clearSearch, resultCount, forwardedRef, + embed, } = props; if (!traceID) { @@ -173,12 +179,18 @@ export function TracePageHeaderFn(props: TracePageHeaderProps) { return (
+ { embed && ( + + )}

{slimView ? : } {name || FALLBACK_TRACE_NAME}

+ { embed && ( + + )} p.serviceName)).size; return (
- {isEmbed && ( -
- - -
- )} {archiveEnabled && ( )} @@ -381,6 +375,9 @@ export class TracePageImpl extends React.PureComponent {!slimView && ( diff --git a/packages/jaeger-ui/src/components/TracePage/index.test.js b/packages/jaeger-ui/src/components/TracePage/index.test.js index 4db32e27ec..4858343b12 100644 --- a/packages/jaeger-ui/src/components/TracePage/index.test.js +++ b/packages/jaeger-ui/src/components/TracePage/index.test.js @@ -39,7 +39,6 @@ import * as track from './index.track'; import { reset as resetShortcuts } from './keyboard-shortcuts'; import { cancel as cancelScroll } from './scroll-page'; import SpanGraph from './SpanGraph'; -import { Button } from 'antd'; import TracePageHeader from './TracePageHeader'; import { trackSlimHeaderToggle } from './TracePageHeader.track'; import TraceTimelineViewer from './TraceTimelineViewer'; @@ -159,11 +158,6 @@ describe('', () => { expect(wrapper.find(SpanGraph).length).toBe(0); }); - it('show buttons with links to the full site and search if is embed', () => { - wrapper.setProps({ isEmbed: true }); - expect(wrapper.find(Button).length).toBe(2); - }); - it('open a window when goFullView is called', () => { wrapper.setProps({ id: '12345' }); global.open = jest.fn();