You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The go bindings have been broken for a while because of upstream changes in open-telemetry/opentracing - they recently merged a PR that will fix golang bindings built from their .proto files
To Reproduce
Steps to reproduce the behavior:
make proto
oh no the golang proto files don't build
Expected behavior
The proto files to build
Screenshots
nope
Version (please complete the following information):
OS: linux
Jaeger version:
Deployment:
What troubleshooting steps did you try?
Additional context
the cause was the upstream proto files depending on generated go that didn't exist anywhere publicly, they now import the correct repository
make proto works, it builds the files - the problem is it generates incorrect go code as detailed above. specifically the imports are wrong because of a mistake on part of open-telemetry/opentelemetry-proto
Describe the bug
The go bindings have been broken for a while because of upstream changes in open-telemetry/opentracing - they recently merged a PR that will fix golang bindings built from their .proto files
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The proto files to build
Screenshots
nope
Version (please complete the following information):
What troubleshooting steps did you try?
Additional context
the cause was the upstream proto files depending on generated go that didn't exist anywhere publicly, they now import the correct repository
The opentracing-proto submodule needs to be bumped to (at least) open-telemetry/opentelemetry-proto@0e254b5
I avoided just making a PR to do this because I'm unsure of any other changes that might affect this repository
The text was updated successfully, but these errors were encountered: