Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generators automatically register in corresponding files #239

Closed
9 tasks done
jadjoubran opened this issue Apr 3, 2016 · 3 comments
Closed
9 tasks done

Generators automatically register in corresponding files #239

jadjoubran opened this issue Apr 3, 2016 · 3 comments

Comments

@jadjoubran
Copy link
Owner

Creating a new component will automatically add a reference to this component in index.components.js
same for services & config

  • add auto-import config
  • components
  • services
  • config
  • filters
  • use auto-import for all generators
  • allow --no-import for all generators
  • update generators here
  • update config here
@flick36
Copy link
Contributor

flick36 commented Apr 4, 2016

Hi, first time commenting, personally, i won't like this feature because i think the John Papa’s Angular Style Guide it's easy and faster to mantain than the folder by feature architecture, in fact i would suggest a refactor on the starter using that styleguide, but of course it's just an opinion. any plans on realising the 3.2? i want to start a project but i'm not sure if i should wait or start using the unestable version

@jadsalhani
Copy link
Collaborator

Hi @flick36

Thanks for the feedback! But I don't see how the starter is in violation of the John Papa style guide? If you take a look at this rule, he personally recommends folder-by-feature + grouping everything inside a main.module.js file

Please note that the starter is using ES6 syntax and not regular Angular 1.5, so we are adapting as much as we can to the StyleGuide while maintaining the correct ES6 naming and syntax.

@jadjoubran
Copy link
Owner Author

Thanks @flick36 for your feedback
As @jadsalhani mentioned, we're doing our best to stick to John Papa's style guide
This feature would only replace the manual work of having to go into the index.components.js file to import the new component (same for filters, services, etc..)

I think 3.2 will be released in the coming 2 weeks
You can start using it though, it's stable most of the times (even though the tests are failing, that's just an issue with the test configuration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants