-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error layout when use DialogManager.dismiss. #6
Comments
Any workarounds on that? |
The issue is only reproducible if you create a dialog via DialogManager as it uses react-native-root-siblings to draw a dialog and can't properly update its props. The workaround is to use the DialogComponent. Note that is should be placed in your top-level element to be rendered correctly, in case you're using react-navigation that would be your screen. |
For anyone having this problem, close your dialog using Disclaimer: This will close the dialog without ANY animation. |
For me, using DialogManager.currentDialog.destroy() indeed fixed the animation issue, but created a new problem - a warning about changing a state of a non-mounted component, and also this preventing Back on Android from working correctly. |
When use DialogManager.dismiss(), dialog width expand to fullscreen then dismiss
The text was updated successfully, but these errors were encountered: