Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved to DFD3: lambdas are not special symbols, and datastore labels … #143

Merged
merged 4 commits into from
Apr 9, 2021

Conversation

izar
Copy link
Collaborator

@izar izar commented Mar 19, 2021

…appear outside of shape

@izar izar requested review from nineinchnick and colesmj March 19, 2021 15:06
@izar
Copy link
Collaborator Author

izar commented Mar 19, 2021

dfd3

label=self._label(),
color=self._color(),
shape=self._shape(),
image=os.path.join(os.path.dirname(__file__), "images", "datastore.png"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image would look better if the top and bottom would not touch, that is if it would be a bit taller.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh just noticed the flow names are broken now. Dammit graphviz.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izar Where is the code that renders the arrows here? Is the shaded vs unshaded arrow heads the implementation of the initiator mark?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a combination of the arrowtail and dir options. arrowtail is always set to onormal (open) but is not drawn by default, when dir is forward. dir is both if a request and response are merged together into a single flow.

Copy link
Collaborator

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Less HTML tables in labels!

@ghost
Copy link

ghost commented Mar 19, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@izar
Copy link
Collaborator Author

izar commented Apr 9, 2021

Talked with @colesmj and made sure he ok's the merge.

@izar izar merged commit a11dfd4 into master Apr 9, 2021
@izar izar deleted the dfd3 branch April 9, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants