-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved to DFD3: lambdas are not special symbols, and datastore labels … #143
Conversation
…appear outside of shape
label=self._label(), | ||
color=self._color(), | ||
shape=self._shape(), | ||
image=os.path.join(os.path.dirname(__file__), "images", "datastore.png"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image would look better if the top and bottom would not touch, that is if it would be a bit taller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh just noticed the flow names are broken now. Dammit graphviz.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@izar Where is the code that renders the arrows here? Is the shaded vs unshaded arrow heads the implementation of the initiator mark?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a combination of the arrowtail
and dir
options. arrowtail
is always set to onormal
(open) but is not drawn by default, when dir
is forward
. dir
is both
if a request and response are merged together into a single flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Less HTML tables in labels!
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
Talked with @colesmj and made sure he ok's the merge. |
…appear outside of shape