Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed image is larger than original #252

Closed
cwRichardKim opened this issue Feb 25, 2017 · 4 comments
Closed

Compressed image is larger than original #252

cwRichardKim opened this issue Feb 25, 2017 · 4 comments

Comments

@cwRichardKim
Copy link

Version

Tell us which versions you are using:

  • react-native-image-crop-picker v0.11.2
  • react-native v0.37.0

Platform

Tell us to which platform this issue is related

  • iOS

Expected behaviour

Compressed image is smaller, or at the very least the same size as the original

Actual behaviour

original (66kb):
1488041806216

just size compression (433kb):
1488043261799

size and image compression (92kb):
14711143_10154622892393064_3707145447315550417_o

Steps to reproduce

ImagePicker.openPicker({
        width: 700,
        height: 700,
        cropping: true,
        compressImageMaxHeight: 700,
        compressImageMaxWidth: 700,
        compressImageQuality: 0.6, // <- removed this for 2nd photo)
      }).then(image => {
        this._uploadPhotoToFirebase(image, index);
      }).catch(error => {
        console.log(error);
      });

Attachments

// stacktrace or any other useful debug info

@fubar
Copy link
Contributor

fubar commented Jan 7, 2018

A change to skip compression in this scenario (#554) will go out with the next release. If you want to retrieve the original image without modification I'd suggest omitting all compressImage* parameters.

@superandrew213
Copy link
Contributor

@ivpusic this can be closed.

@ivpusic
Copy link
Owner

ivpusic commented May 25, 2018

tnx @superandrew213

@ivpusic
Copy link
Owner

ivpusic commented Jun 26, 2018

fixed by #736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants