Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting 'allowJs' and 'declaration' options causes 'emit failed' error #356

Closed
LPGhatguy opened this issue May 25, 2016 · 3 comments
Closed

Comments

@LPGhatguy
Copy link

This is very close to a continuation of #259.

I have a template project with typings output that has the option to source JS, but doesn't ship with any JS source. As such, declaration and allowJs are both set to true. This causes an emit failed error.

There are some closed issues that talk about this combination, but I'm not expecting typings to output from the JS portion of the code -- I just want everything to process successfully, or at least output with a useful error message!

Here's a repository that reproduces the error with just gulp, gulp-typescript, and merge-stream:

https://github.com/LPGhatguy/gulp-typescript-allowjs-bug

@ivogabe
Copy link
Owner

ivogabe commented May 25, 2016

Looks like a duplicate of #317 and microsoft/TypeScript#7546

@LPGhatguy
Copy link
Author

The behavior described by #317 implies that compilation succeeds, and JS is ignored, which would be okay, but the reply on the TypeScript error talks about there being an error.

@ivogabe
Copy link
Owner

ivogabe commented Dec 11, 2016

Closing this in favour of microsoft/TypeScript#7546.

@ivogabe ivogabe closed this as completed Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants