Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8.decode is not a function #422

Open
MillerGregor opened this issue Jan 21, 2018 · 2 comments
Open

utf8.decode is not a function #422

MillerGregor opened this issue Jan 21, 2018 · 2 comments

Comments

@MillerGregor
Copy link

For anyone else getting this error:

There's a naming collision between the "utf8" package and react-native's internal utf8 library.

@eacbkk forked utf8 to rename it:
https://github.com/eacbkk/utf8.js

I forked @tianling536's fork of react-native-fs to avoid the utf8 error and get RN 0.5x.x support:

https://github.com/Gregor1971/react-native-fs

... and this
https://github.com/Gregor1971/redux-persist-fs-storage

@itinance
Copy link
Owner

Do you want to submit a PR?

@MillerGregor
Copy link
Author

MillerGregor commented Jan 22, 2018

I don't know if a PR makes sense here. The forked utf8 package isn't published, so I'm using github urls in the package.json files - probably not something you want to make "official".

I think the react-native team will come up with a good solution. They're discussing it: facebook/react-native#17146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants