Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also dd P256VERIFY to 0x100 as defined in RIP #125

Closed
mattsse opened this issue Jan 7, 2025 · 2 comments · Fixed by #126
Closed

also dd P256VERIFY to 0x100 as defined in RIP #125

mattsse opened this issue Jan 7, 2025 · 2 comments · Fixed by #126
Assignees
@Dhruv-2003
Labels
D-good-first-issue Good for newcomers

Comments

@mattsse
Copy link
Member

mattsse commented Jan 7, 2025

we currently use 0x14 as the precompile address

we also should add it to 0x100 as defined in the RIP

ref anvil pr:

foundry-rs/foundry#9618
@mattsse mattsse added the D-good-first-issue Good for newcomers label Jan 7, 2025
@Dhruv-2003
Copy link
Contributor

hey @mattsse, could you assign this to me ?

@onbjerg
Copy link
Member

onbjerg commented Jan 7, 2025

@Dhruv-2003 I've assigned you, please also provide tests that show that the precompile is available on the address it is now (for backwards compatibility) and 0x100

@Dhruv-2003 Dhruv-2003 mentioned this issue Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dhruv-2003 Dhruv-2003

Labels
D-good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added P256Verify precompile to 0x100 Dhruv-2003/odyssey
3 participants
@onbjerg @mattsse @Dhruv-2003