Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #61 once docker/cli#2934 gets released #62

Open
0x2b3bfa0 opened this issue Feb 22, 2021 · 2 comments
Open

Revert #61 once docker/cli#2934 gets released #62

0x2b3bfa0 opened this issue Feb 22, 2021 · 2 comments
Labels
resource-runner iterative_runner TF resource technical-debt Refactoring, linting & tidying

Comments

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Feb 22, 2021 •
edited
Loading

Once docker/cli#2934 gets released, the changes introduced with #61 won't be required anymore and should be reverted.
@0x2b3bfa0 0x2b3bfa0 added the technical-debt Refactoring, linting & tidying label Apr 14, 2021
@0x2b3bfa0 0x2b3bfa0 added the resource-runner iterative_runner TF resource label Apr 24, 2022
@dacbd
Copy link
Contributor

dacbd commented Apr 29, 2022

@iterative/cml Is this something that should actually change at this point? aka not using a temp dir?

I feel it is pretty safe to close.

@casperdcl
Copy link
Contributor

I'd prefer removal of redundant fixes

@dacbd dacbd mentioned this issue May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resource-runner iterative_runner TF resource technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dacbd @casperdcl @0x2b3bfa0