Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image caching broken #2897

Closed
casperdcl opened this issue Oct 5, 2021 · 3 comments · Fixed by #2851
Closed

image caching broken #2897

casperdcl opened this issue Oct 5, 2021 · 3 comments · Fixed by #2851
Labels
🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc

Comments

@casperdcl
Copy link
Contributor

casperdcl commented Oct 5, 2021

after updating an image in #2895 (merged) the website (https://dvc.org/doc/use-cases/ci-cd-for-machine-learning -> https://dvc.org/static/1b000d95083794b7ebfb4e8b901881f1/7cae1/cicd4ml-1.png) hasn't updated. Running yarn develop locally also doesn't show the updated image either.

/CC @rogermparent @julieg18

@casperdcl casperdcl added 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc labels Oct 5, 2021
@rogermparent
Copy link
Contributor

This is part of our old pinned image caching that we have as a workaround to the caching issue we're fixing right now, talked about on a comment in this ticket we participated in a while ago

I do get where you're coming from, but this is not a bug, nor a regression. The previous caching behavior for sharp wasn't correct. You could change the input file's content and your file would not recreate the image.

Funny that it's coming up right now.

@julieg18
Copy link
Contributor

julieg18 commented Oct 5, 2021

As a temporary solution, until we can fix our caching, we could rename the image file. That should force gatsby to update it 🤔

@rogermparent
Copy link
Contributor

Closing since this should be fixed by #2851, but if it happens again we can re-open this.

@casperdcl casperdcl linked a pull request Oct 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants